Fix IIIF response headers and content-type detection #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply response_headers from DataRequest to all send methods (send_buffered, send_stream, send_temporary_file) - Auto-detect proper content-type based on output format instead of defaulting to application/octet-stream - Add format_to_content_type mapping for common image formats (JPEG, PNG, WebP, TIFF, etc.) - Preserve custom content-type headers when explicitly set in DataRequest.response_headers - Add comprehensive tests for content-type detection across all send methods - Add test plug for custom content-type scenarios This fixes the issue where IIIF images were being served with incorrect content-type headers causing browsers to download files instead of displaying them inline.
dersmon
requested changes
Aug 1, 2025
lib/iiif_image_plug/v3.ex
Outdated
Comment on lines
396
to
398
| # Use the requested format for content-type (since that's what we're delivering) | ||
| conn = put_resp_content_type_from_format(conn, format) | ||
|
|
There was a problem hiding this comment.
Maybe we could add these calls between line 329 and 330, before it branches off to the different response types?
As suggested in PR review, move the put_resp_content_type_from_format call to occur before the cond statement that branches into different response methods. This ensures consistent content-type handling across all response paths (send_buffered, send_temporary_file, and send_stream).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Content-Type headers in IIIF responses
The library was not setting Content-Type headers, causing them to fall back to application/octet-stream. This fix ensures proper content-type headers are set based on the requested output format (image/jpeg, image/png, etc).