-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduces macos and windows runners in build step #279
base: master
Are you sure you want to change the base?
Conversation
This PR is almost 1y old. Can a review be provided please ? |
@bobrossthepainter what's the state of this? does it make sense to have this merged in? |
# echo "::set-output name=matrix::$matrix" | ||
|
||
# MacOs Single Test | ||
matrix=$( echo '{"version":["ApiServerContainer 1.30.0"],"os":["macos-12"]}' | jq -c '.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cmoulliard, thanks almost forgot this PR. I will provide an update here within the next week.
if: runner.os == 'macos' | ||
run: | | ||
brew install docker colima docker-buildx | ||
colima start --network-address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use colima
and not podman
?
Verifies working developer-builds on different os'