Fix performance bottleneck with scaling defines#128
Open
yousifBilal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a problem where I had a file with a lot of macro definitions (~ 1 million). The preprocessor just get stuck. With this change we get better results:
Pre change
Post change
One change is regarding the skip_nodes. It was growing with each. Even though we never need the nodes that we exited from again. Also, the push to the skip nodes will just return once it found the
LocateThe other change is to avoid copying the list of defines when we need to expand macros recursively, rather, we pass in a mutable reference to the defines map.