Bump rand_core to v0.10.0-rc-3
#860
Merged
+87
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes in this PR are actually from the associated `rand` crate updates which are happening in rust-random/rand#1697, notably `OsRng` has been renamed to `SysRng` (and is now provided by the `getrandom` crate). We do use some `rand_core` APIs in a few places though, like the STROBE implementation, where this migrates from `rand_core::le` to `rand_core::utils`.
tarcieri
commented
Dec 27, 2025
Comment on lines
+18
to
+20
| # https://github.com/rust-random/rand/pull/1697 | ||
| rand = { git = "https://github.com/rust-random/rand", rev = "99ae06fb348e5c5fee0fe41d2201bd4cbb107635" } | ||
| getrandom = { git = "https://github.com/rust-random/getrandom.git", rev = "f67c70110f706f80d7dd6fa52e38d0920754fe2c" } |
Contributor
Author
There was a problem hiding this comment.
Could go either way on waiting for these to be merged. Right now the build is broken on main, so I feel like getting it fixed would probably be for the best, even if we temporarily have some patches to do it.
rozbb
approved these changes
Dec 27, 2025
Contributor
rozbb
left a comment
rozbb
left a comment
There was a problem hiding this comment.
Thank you for catching this!
Contributor
|
Needs a release still, getting some conflicts (through aead's) between pinned rc's. |
carloskiki
pushed a commit
to carloskiki/curve25519-dalek
that referenced
this pull request
Jan 3, 2026
Most of the changes in this PR are actually from the associated `rand` crate updates which are happening in rust-random/rand#1697, notably `OsRng` has been renamed to `SysRng` (and is now provided by the `getrandom` crate). We do use some `rand_core` APIs in a few places though, like the STROBE implementation, where this migrates from `rand_core::le` to `rand_core::utils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes in this PR are actually from the associated
randcrate updates which are happening in rust-random/rand#1697, notablyOsRnghas been renamed toSysRng(and is now provided by thegetrandomcrate).We do use some
rand_coreAPIs in a few places though, like the STROBE implementation, where this migrates fromrand_core::letorand_core::utils.