ensure closeasync is called for lost sessions and messages #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reintroduce transactionscope for orchestrator/activity completion to handle cases where connection is lost or servicebus interruption happens.
Exceptions in CompleteMessageAsync prevent CloseAsync from being called. Based on azure SDK this will prevent messages from being replayed in the event of session lost or message lost. Therefore, this change uses a finally block to ensure that CloseAsync is called.
Some tests are not idempotent and will not run unless the underlying store is cleaned up, so those are added.
Some tests fail to write to Table instance store unless the DateTime kind is specified as UTC.
QueryOrchestrationStatesSegmentedAsync was not correctly deserializing state. The AMS library does not support continuation tokens and instead uses AsyncPageable. This change fixes the deserialization, and support for continuation token will be in a future change.
Bump version to 2.7.4.1