Skip to content

feat: Migrate integration tests to Cucumber BDD format #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yacosta738 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Migrate integration tests to Cucumber BDD format #230

yacosta738 wants to merge 1 commit into from

Conversation

@yacosta738
Copy link
Contributor

@yacosta738 yacosta738 commented Nov 18, 2025

Migrates all existing integration tests from JUnit/Kotest to Cucumber BDD format.

  • Creates Gherkin feature files for all test scenarios.
  • Implements reusable Kotlin step definitions.
  • Removes old *IntegrationTest.kt files.

@google-labs-jules
feat: Migrate integration tests to Cucumber BDD format
678ee65 
Migrates all existing integration tests from JUnit/Kotest to Cucumber BDD format.

- Creates Gherkin feature files for all test scenarios.
- Implements reusable Kotlin step definitions.
- Removes old `*IntegrationTest.kt` files.

Note: There are pre-existing issues with Testcontainers that cause some tests to fail. This submission includes the complete migration, but the test failures will need to be addressed separately.
@github-actions github-actions bot added the area:backend Changes in backend code (server/**) label Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Test Results

130 files   - 12  130 suites   - 12   53s ⏱️ -11s
568 tests  - 63  566 ✅  - 65  0 💤 ±0  2 ❌ +2 
572 runs   - 63  570 ✅  - 65  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 678ee65. ± Comparison against base commit c219438.

This pull request removes 74 and adds 11 tests. Note that renamed tests count towards both. 
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [1] com.loomify.common.domain.bus.ContinueOnExceptionPublishStrategy@1def0269
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [2] com.loomify.common.domain.bus.ParallelNoWaitPublishStrategy@2e273fd4
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [3] com.loomify.common.domain.bus.ParallelWhenAllPublishStrategy@252fac6f
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [4] com.loomify.common.domain.bus.StopOnExceptionPublishStrategy@3b0e19f0
com.loomify.engine.authentication.infrastructure.AuthenticationExceptionAdviceIT ‑ shouldHandleNotAuthenticatedUserException()
com.loomify.engine.authentication.infrastructure.AuthenticationExceptionAdviceIT ‑ shouldHandleUnknownAuthenticationException()
com.loomify.engine.authentication.infrastructure.SecurityConfigurationIT ‑ shouldUserAuthoritiesMapperWithOidcUserAuthority()
com.loomify.engine.authentication.infrastructure.SecurityConfigurationIT ‑ shouldUserAuthoritiesMapperWithSimpleGrantedAuthority()
com.loomify.engine.authentication.infrastructure.http.SessionControllerIntegrationTest ‑ should return 401 when access token cookie is missing
com.loomify.engine.authentication.infrastructure.http.SessionControllerIntegrationTest ‑ should return 401 when access token has invalid format
…

com.loomify.common.domain.bus.MediatorBuilderTest ‑ [1] com.loomify.common.domain.bus.ContinueOnExceptionPublishStrategy@44d9c088
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [2] com.loomify.common.domain.bus.ParallelNoWaitPublishStrategy@10ad4b41
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [3] com.loomify.common.domain.bus.ParallelWhenAllPublishStrategy@6a865af8
com.loomify.common.domain.bus.MediatorBuilderTest ‑ [4] com.loomify.common.domain.bus.StopOnExceptionPublishStrategy@7a051398
com.loomify.engine.authentication.infrastructure.http.UserAuthenticatorControllerIntegrationTest ‑ should authenticate user()
com.loomify.engine.authentication.infrastructure.http.UserLogoutControllerIntegrationTest ‑ should logout user()
com.loomify.engine.authentication.infrastructure.persistence.keycloak.KeycloakAuthenticatorRepositoryIntegrationTest ‑ should authenticate with keycloak()
com.loomify.engine.authentication.infrastructure.persistence.keycloak.KeycloakLogoutRepositoryIntegrationTest ‑ should logout from keycloak()
com.loomify.engine.authentication.infrastructure.persistence.keycloak.KeycloakRefreshTokenManagerRepositoryIntegrationTest ‑ should refresh token with keycloak()
com.loomify.engine.users.infrastructure.http.AccountResourceControllerIntegrationTest ‑ should get account()
…

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Qodana for JVM

71 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 41
Invalid YAML configuration 🔶 Warning 5
Unstable API Usage 🔶 Warning 4
Duplicated code fragment ◽️ Notice 11
Unknown HTTP header ◽️ Notice 5
Redundant escaped dollar characters in string literals ◽️ Notice 3
Multi-dollar interpolation can be used in string literals (available since 2.1) ◽️ Notice 1
Accessor call that can be replaced with property access syntax ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:backend Changes in backend code (server/**)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yacosta738