rp2040,rp2350: Don't enable interrupts during Initialize_Board#28
Merged
Conversation
The runtime does not expect interrupts to be enabled at this point, and the runtime will enable interrupts later once everything else is initialized. Having interrupts trigger early can cause a crash since the Interrupt_Wrapper will try to change task priorities before threads are initialized. Fixes community-bb-runtimes#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime does not expect interrupts to be enabled at this point, and the runtime will enable interrupts later once everything else is initialized. Having interrupts trigger early can cause a crash since the Interrupt_Wrapper will try to change task priorities before threads are initialized.
Also added a test to verify that exception propagation works correctly, since the original report on the Ada forum indicated that their problem only occurred when
Ada.Exceptionswas used. Though this turned out to be a red herring in the end.Fixes #27