Skip to content

temp range indicators #746

Merged
damongolding merged 1 commit into
task/releasefrom
feature/temp-range-indicators
May 7, 2026
Merged

temp range indicators #746
damongolding merged 1 commit into
task/releasefrom
feature/temp-range-indicators

Conversation

@damongolding

@damongolding damongolding commented May 7, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Style
    • Enhanced visual styling for temperature range display in the weather section, improving the presentation of high and low temperature values.

@damongolding damongolding added the enhancement New feature or request label May 7, 2026
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55c8ca56-8871-4d49-8a6f-7ad66d231b84

📥 Commits

Reviewing files that changed from the base of the PR and between 1024d3d and 01f8b70.

📒 Files selected for processing (2)
  • frontend/src/css/weather.css
  • internal/templates/partials/weather.templ

Walkthrough

The PR refactors temperature range display in the weather widget by wrapping high and low values in dedicated DOM spans, enabling targeted CSS styling with pseudo-element indicators positioned above and below their respective values.

Changes

Temperature Range Indicators

Layer / File(s) Summary
Template DOM Structure
internal/templates/partials/weather.templ
High and low temperature values are wrapped in separate <span> elements with class names weather--temperature-range--value--high and weather--temperature-range--value--low, replacing inline rendering whilst preserving separator and degree symbols.
Indicator Styling
frontend/src/css/weather.css
New CSS classes for high and low value variants add position: relative and ::before pseudo-elements that render as centred horizontal bars with semi-transparent white background, positioned near the top for high values and near the bottom for low values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • damongolding/immich-kiosk#625: Both PRs modify internal/templates/partials/weather.templ and could have overlapping changes or dependency interactions.

Poem

🐰 A span wraps each high and low,
With bars above and beneath below,
The weather shines with new flair,
Indicators floating with style and care! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'temp range indicators' clearly and concisely describes the main change: adding visual indicators (styling via pseudo-elements) for temperature range values in the weather display.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/temp-range-indicators

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@damongolding damongolding changed the title added feat temp range indicators May 7, 2026
@damongolding damongolding merged commit 02457b6 into task/release May 7, 2026
3 checks passed
@damongolding damongolding deleted the feature/temp-range-indicators branch June 15, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant