Skip to content

Conversation

danieldaquino
Copy link
Collaborator

This PR allows us to separate free install instructions from premium/paid ones.

Test

api: abcdd1f
website: 322171d3f9a8c92568b822c54568021495d767e2
Setup: Local testing setup

  1. Moved .env away temporarily and ran npm test. Tests passing
  2. Ran npm run type-check-compare. No new type warnings or errors
  3. Performed functional test:
    1. Went to the page without any login. Confirmed the free instructions appear
    2. Logged in. Confirmed that the paid instructions appear
    3. Forcibly modified session token to "null". Confirmed the free instructions appear
    4. Forcibly modified session token to a random number. Confirmed the free instructions appear
    5. Forcibly deleted session token. Confirmed the free instructions appear
    6. Forcibly recovered session token to a valid one. Confirmed the paid instructions appear

Results: PASS

This helps us quickly sift through and see new type issues we
introduced.

Even if we don't go back to fix the previous type warnings, at least we
should prevent new type issues.

Signed-off-by: Daniel D’Aquino <[email protected]>
@danieldaquino
Copy link
Collaborator Author

All CI tests passing:

# { total: 579, pass: 579 }
# time=51687.737ms
Error: Process completed with exit code 1.

It's marked as a fail due to known CI configuration issue: #10

@danieldaquino danieldaquino requested a review from jb55 May 2, 2025 23:05
@jb55 jb55 merged commit 8ff20f0 into damus-io:master May 3, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants