ui: add ndb search to universe view #2464
Conversation
This PR adds the NDB search functionality from the pull down search in the posting timeline to the universe view. Changelog-Added: Added NDB search functionality to the universe view Signed-off-by: ericholguin <[email protected]>
|
I didn't see this until now... will test soon after these ios18 fixes land |
|
testing this now |
There was a problem hiding this comment.
Thank you @ericholguin! I really liked this new feature, I think it significantly improves search UX.
I just added two minor comments, but otherwise looks good to me!
| .overlay( | ||
| RoundedRectangle(cornerRadius: 20) | ||
| .stroke(DamusColors.neutral3, lineWidth: 1) | ||
| ) |
There was a problem hiding this comment.
We should define this gray button style as a reusable view, to reduce code duplication between TextSearch and HashtagSearch
| HStack { | ||
| HashtagSearch(multi.hashtag) | ||
| TextSearch(multi.text) | ||
| } |
There was a problem hiding this comment.
I feel like we should add more spacing between these buttons and the profile search results below it.
Right now the spacing between the button and the top looks much larger than the button and the profile results below it, making it look a bit asymmetrical.
William Casarin (3):
search: use lazyvstack
search: expand search results to 128
ericholguin (1):
ui: add ndb search to universe view
|
merged and expanded the search results to 128! |
4 participants
This PR adds the NDB search functionality from the pull down search in the posting timeline to the universe view.
https://v.nostr.build/LtG2oHq7kUUPuMKX.mp4
Changelog-Added: Added NDB search functionality to the universe view