Fix profile pic banner pic upload #2614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right to me! |
|
although nostr.build supports uploads without auth right? was it not working because the image was too large? |
jb55
approved these changes
Oct 24, 2024
I thought it would support but as of now, the following is the response sent by nostr-build There is one more commit that limits the profile and banner upload to image only and sets selection quantity to 1 |
jb55
requested changes
Oct 26, 2024
damus/Views/MediaPicker.swift
Outdated
Comment on lines
122
to
129
| if case .postView = mediaPickerEntry { | ||
| configuration.selectionLimit = 0 // Allows multiple media selection | ||
| configuration.filter = .any(of: [.images, .videos]) | ||
| configuration.selection = .ordered // images are returned in the order they were selected + numbered badge displayed | ||
| } else if case .editPictureControl = mediaPickerEntry { | ||
| configuration.selectionLimit = 1 // Allows one media selection | ||
| configuration.filter = .images | ||
| } |
There was a problem hiding this comment.
@jb55 I have made the update
Use Switch statement to address all cases instead of if-else Signed-off-by: Swift Coder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing picture-upload flow for Profile and Banner is broken. Root cause analysis of this bug is due to missing KeyPair parameter being passed while instantiating EditPictureControl objects. They KeyPair param is used to create nip98 signature and which is eventually used to create an "Authorization" header for creating an upload request.
Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches