Fixed missing tab bar while navigating #2718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set isSidebarVisible to false Changelog-Fixed: missing tab bar on navigation Signed-off-by: Swift Coder <[email protected]>
alltheseas
added this to the
1.11 - video player, bugfixes, onboarding (formerly lists) milestone
|
Merged! Thank you @scoder1747! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed missing tab bar observed while navigating by tapping on top profile part of Side menu.
Root cause analysis:
isSidebarVisible was not set to false
Video showing the issue:
r18b.mov
After fixing the issue:
r18f.mov
[Please provide a summary of the changes in this PR.]
Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches