wallet: Add fiat pricing to Wallet View #3001
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,84 @@ | ||||||
| // | ||||||
| // CoinbaseModel.swift | ||||||
| // damus | ||||||
| // | ||||||
| // Created by eric on 4/24/25. | ||||||
| // | ||||||
|
|
||||||
| import Foundation | ||||||
| import SwiftUI | ||||||
|
|
||||||
| class CoinbaseModel: ObservableObject { | ||||||
|
|
||||||
| @Published var btcPrice: Double? = nil { | ||||||
| didSet { | ||||||
| if let btcPrice = btcPrice { | ||||||
| cachePrice(btcPrice) | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| var cacheKey: String { | ||||||
| "btc_price_\(currency.lowercased())" | ||||||
| } | ||||||
|
|
||||||
| var currency: String = Locale.current.currency?.identifier ?? "USD" | ||||||
|
|
||||||
| let numberFormatter: NumberFormatter = { | ||||||
| let formatter = NumberFormatter() | ||||||
| formatter.locale = Locale.current | ||||||
| formatter.numberStyle = .decimal | ||||||
| formatter.maximumFractionDigits = 2 | ||||||
| return formatter | ||||||
| }() | ||||||
|
|
||||||
| func satsToFiat(input: Int64) -> String { | ||||||
| guard let btcPrice = btcPrice, input > 0 else { | ||||||
| return "" | ||||||
|
There was a problem hiding this comment. We should use more expressive semantics of the result, and let the view choose how to handle failures. Instead of defaulting to an empty string or value when something fails, we should:
|
||||||
| } | ||||||
| let fiat = (Double(input) / 100_000_000) * btcPrice | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| let amount = numberFormatter.string(from: NSNumber(value: fiat)) ?? "" | ||||||
| let symbol: String = numberFormatter.currencySymbol | ||||||
| if symbol.isEmpty || symbol == currency { | ||||||
| return amount + " " + currency | ||||||
| } | ||||||
| return symbol + amount + " " + currency | ||||||
|
There was a problem hiding this comment. This seems to be making some assumptions about currency value formatting that might not be true for some locales. I believe Apple provides a way to format currencies in a simpler and localization-friendly way, by using |
||||||
| } | ||||||
|
|
||||||
| func fetchFromCoinbase() { | ||||||
| let urlString = "https://api.coinbase.com/v2/prices/BTC-\(currency)/spot" | ||||||
| guard let url = URL(string: urlString) else { return } | ||||||
|
|
||||||
| Task { | ||||||
| do { | ||||||
| let (data, _) = try await URLSession.shared.data(from: url) | ||||||
| let decoded = try JSONDecoder().decode(CoinbaseResponse.self, from: data) | ||||||
| DispatchQueue.main.async { | ||||||
| self.btcPrice = decoded.data.amount | ||||||
| } | ||||||
| } catch { | ||||||
| print("Failed to fetch BTC price from Coinbase: \(error)") | ||||||
|
There was a problem hiding this comment. I am a bit worried about how this error is being handled. If something is broken or the API stops working, the interface will just keep displaying the last known value forever, which might be misleading and hard to notice. |
||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| private func cachePrice(_ price: Double) { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| UserDefaults.standard.set(price, forKey: cacheKey) | ||||||
| } | ||||||
|
|
||||||
| func loadCachedPrice() { | ||||||
| let cached = UserDefaults.standard.double(forKey: cacheKey) | ||||||
| if cached > 0 { | ||||||
| btcPrice = cached | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| struct CoinbaseResponse: Codable { | ||||||
| let data: CoinbasePrice | ||||||
| } | ||||||
|
|
||||||
| struct CoinbasePrice: Codable { | ||||||
| let amount: Double | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
|
There was a problem hiding this comment. nitpick tip: The structs struct CoinbaseModel {
...
struct Response: Codable {
let data: Price
struct Price: Codable {
let amount: Double
}
}
} |
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,13 +9,18 @@ import SwiftUI | |||||||||||||||||||
|
|
||||||||||||||||||||
| struct BalanceView: View { | ||||||||||||||||||||
| var balance: Int64? | ||||||||||||||||||||
| @StateObject private var coinbase = CoinbaseModel() | ||||||||||||||||||||
|
|
||||||||||||||||||||
| var body: some View { | ||||||||||||||||||||
| VStack(spacing: 5) { | ||||||||||||||||||||
| Text("Current balance", comment: "Label for displaying current wallet balance") | ||||||||||||||||||||
| .foregroundStyle(DamusColors.neutral6) | ||||||||||||||||||||
| if let balance { | ||||||||||||||||||||
| self.numericalBalanceView(text: NumberFormatter.localizedString(from: NSNumber(integerLiteral: Int(balance)), number: .decimal)) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Text(coinbase.satsToFiat(input: balance)) | ||||||||||||||||||||
| .fontWeight(.medium) | ||||||||||||||||||||
| .foregroundStyle(DamusColors.neutral6) | ||||||||||||||||||||
|
Comment on lines
+21
to
+23
There was a problem hiding this comment. If
Suggested change
Copilot uses AI. Check for mistakes. |
||||||||||||||||||||
| } | ||||||||||||||||||||
| else { | ||||||||||||||||||||
| // Make sure we do not show any numeric value to the user when still loading (or when failed to load) | ||||||||||||||||||||
|
|
@@ -25,7 +30,12 @@ struct BalanceView: View { | |||||||||||||||||||
| .shimmer(true) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
| .onAppear { | ||||||||||||||||||||
| coinbase.loadCachedPrice() | ||||||||||||||||||||
| coinbase.fetchFromCoinbase() | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| func numericalBalanceView(text: String) -> some View { | ||||||||||||||||||||
| HStack { | ||||||||||||||||||||
|
|
@@ -43,7 +53,7 @@ struct BalanceView: View { | |||||||||||||||||||
| .foregroundStyle(PinkGradient) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
| .padding(.bottom, 5) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ struct WalletView: View { | |
| ) | ||
| } | ||
|
|
||
| VStack(spacing: 10) { | ||
|
|
||
| BalanceView(balance: model.balance) | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.