Add NIP-88 polls support #3253

alltheseas · 2025-10-10T19:31:51Z

Summary

-Added NIP-88 poll event kinds and a shared PollResultsStore, wiring poll support through DamusState, HeadlessDamusState, and the notification extension.

Introduced poll domain models (events, responses, drafts, vote builder) plus logic for sanitising votes, deduplicating by pubkey, and managing relay
subscriptions.
Upgraded the composer with a dedicated poll UI, validation (no media/mentions, unique options, future expiry), relay tagging, and NIP-37 draft persistence
for polls.
Rendered polls in the timeline via a new PollEventView, enabling voting, enforcing “vote after view,” and showing results only post-vote or expiry.
Localised new strings and added poll unit tests for event parsing and vote submission logic.

Checklist

I have read (or I am familiar with) the Contribution Guidelines
I have tested the changes in this PR
I have opened or referred to an existing github issue related to this change. Polls #401
My PR is either small, or I have split it into smaller logical commits that are easier to review
I have added the signoff line to all my commits. See Signing off your work
I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
- I do not need to add a changelog entry. Reason: [Please provide a reason]
I have added appropriate Closes: or Fixes: tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches

Test report

Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.

Device: [Please specify the device you used for testing]

iOS: [Please specify the iOS version you used for testing]

Damus: [Please specify the Damus version or commit hash you used for testing]

Setup: [Please provide a brief description of the setup you used for testing, if applicable]

Steps: [Please provide a list of steps you took to test the changes in this PR]

Results:

PASS
Partial PASS
- Details: [Please provide details of the partial pass]

Other notes

[Please provide any other information that you think is relevant to this PR.]

alltheseas · 2025-10-10T19:32:20Z

note this is 100% pure vibe generated on a non-mac machine, and untested. will attempt testing now on xcode/macos

Copilot

Pull Request Overview

This PR implements NIP-88 polls support in Damus, adding comprehensive poll functionality including creation, voting, and results display. The implementation introduces domain models for polls, a shared store for managing poll state, and integrates polling capabilities throughout the app.

Introduces poll domain models (PollEvent, PollResponse, PollDraft) and supporting infrastructure
Adds a PollResultsStore for managing poll state and vote submission with relay subscriptions
Integrates poll UI components in the composer and timeline with validation and voting functionality

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
damusTests/PollTests.swift	Adds unit tests for poll event parsing and vote submission logic
damusTests/Mocking/MockDamusState.swift	Updates mock state to include poll store
damus/TestData.swift	Updates test data to include poll store
damus/Shared/Utilities/HeadlessDamusState.swift	Adds polls property to headless state protocol
damus/Features/Timeline/Models/HomeModel.swift	Adds poll event handling and subscription filters
damus/Features/Posting/Views/PostView.swift	Integrates poll composer UI and validation logic
damus/Features/Posting/Models/Post.swift	Adds poll kind handling in event creation
damus/Features/Posting/Models/DraftsModel.swift	Adds poll draft support to draft artifacts
damus/Features/Polls/Views/PollEventView.swift	Implements poll display and voting UI
damus/Features/Polls/Views/PollComposerView.swift	Implements poll creation interface
damus/Features/Polls/Models/PollVoteBuilder.swift	Handles poll response event creation
damus/Features/Polls/Models/PollResultsStore.swift	Manages poll state and vote submission
damus/Features/Polls/Models/PollModels.swift	Defines poll domain models and parsing logic
damus/Features/Polls/Models/PollDraft.swift	Defines poll draft structure for composition
damus/Features/Events/EventView.swift	Adds poll event rendering support
damus/Core/Storage/DamusState.swift	Integrates poll store into main app state
damus/Core/Nostr/NostrKind.swift	Adds poll and poll_response event kinds
damus.xcodeproj/project.pbxproj	Updates project file with new poll-related source files
DamusNotificationService/NotificationExtensionState.swift	Adds poll store to notification extension state

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-10T19:36:22Z

damus/Features/Timeline/Models/HomeModel.swift

    }

    func subscribe_to_home_filters(friends fs: [Pubkey]? = nil, relay_id: RelayURL? = nil) {
        // TODO: separate likes?


[nitpick] Consider grouping poll-related kinds together or adding a comment explaining the ordering rationale for better code organization.

Suggested change

// TODO: separate likes?

// TODO: separate likes?

// The ordering of kinds below is intentional for timeline display.

// Only one poll-related kind (.poll) exists currently; if more are added, group them together.

Copilot · 2025-10-10T19:36:23Z

damus/Features/Posting/Views/PostView.swift

    func send_post() {
-        let new_post = build_post(state: self.damus_state, post: self.post, action: action, uploadedMedias: uploadedMedias, references: self.references, filtered_pubkeys: filtered_pubkeys)
+        let new_post = build_post(state: self.damus_state, post: self.post, action: action, uploadedMedias: uploadedMedias, references: self.references, filtered_pubkeys: filtered_pubkeys, pollDraft: pollDraft)


[nitpick] This function call has many parameters. Consider creating a struct to encapsulate these parameters for better readability and maintainability.

Copilot · 2025-10-10T19:36:23Z

damus/Features/Polls/Views/PollEventView.swift

+//  PollEventView.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-04-02.

Copilot · 2025-10-10T19:36:23Z

damus/Features/Polls/Views/PollComposerView.swift

+//  PollComposerView.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-04-02.

Copilot · 2025-10-10T19:36:24Z

damus/Features/Polls/Models/PollVoteBuilder.swift

+//  PollVoteBuilder.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-04-02.

Copilot · 2025-10-10T19:36:24Z

damus/Features/Polls/Models/PollResultsStore.swift

+//  PollResultsStore.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-06-10.

Copilot · 2025-10-10T19:36:24Z

damus/Features/Polls/Models/PollModels.swift

+//  PollModels.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-06-10.

Copilot · 2025-10-10T19:36:25Z

damus/Features/Polls/Models/PollDraft.swift

+//  PollDraft.swift
+//  damus
+//
+//  Created by ChatGPT on 2025-04-02.


The creation date 2025-04-02 appears to be in the future relative to when this was likely created. Consider updating to the actual creation date.

Suggested change

// Created by ChatGPT on 2025-04-02.

// Created by ChatGPT on 2024-04-02.

• Add unit tests • Add poll rendering across timeline/profile flows

alltheseas · 2025-10-12T05:00:25Z

In latsst commit I was able to

create a nip-88 poll
see a poll created by another nip-88 client

jb55 · 2025-10-12T17:28:53Z

note this is 100% pure vibe generated on a non-mac machine, and untested. will attempt testing now on xcode/macos

can you clarify what you mean by untested? does it work ?

alltheseas · 2025-10-12T18:52:00Z

The initial commit was untested as I produced the code on a Linux machine. Afterwards, I ported the PR to a macOS with Xcode.

The subsequent commits ensures that the build compiles and that polls events can be both generated, and seen.

I have confirmed that creating polls, and seeing polls, and responding to polls works on the latest commit.

The PR is ready for your review.

alltheseas · 2025-10-12T18:52:37Z

Yes, nip-88 polls worked for me on xcode iOS simulator

Add NIP-88 polls support. Untested PR.

7c13e15

alltheseas requested review from Copilot, danieldaquino and jb55 October 10, 2025 19:34

Copilot AI reviewed Oct 10, 2025

View reviewed changes

alltheseas and others added 2 commits October 10, 2025 16:58

Fix target membership and poll kind handling

b172347

• Fix builds

6490859

• Add unit tests • Add poll rendering across timeline/profile flows

alltheseas changed the title ~~Add NIP-88 polls support. Untested PR.~~ Add NIP-88 polls support Oct 12, 2025

alltheseas mentioned this pull request Oct 12, 2025

Polls [NIP-88] Positive Interoperability Tracker nostrability/nostrability#220

Open

alltheseas added the experimental label Oct 17, 2025

alltheseas mentioned this pull request Oct 17, 2025

feat: gate nip-88 polls behind a feature flag #3265

Open

	// Created by ChatGPT on 2025-04-02.
	// Created by ChatGPT on 2024-04-02.

	// Created by ChatGPT on 2025-04-02.
	// Created by ChatGPT on 2024-06-10.

Add NIP-88 polls support #3253

Are you sure you want to change the base?

Add NIP-88 polls support #3253

Uh oh!

Conversation

alltheseas commented Oct 10, 2025

Summary

Checklist

Test report

Other notes

Uh oh!

alltheseas commented Oct 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

alltheseas commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jb55 commented Oct 12, 2025

Uh oh!

alltheseas commented Oct 12, 2025

Uh oh!

alltheseas commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alltheseas commented Oct 12, 2025 •

edited

Loading