longform: Fix NIP-19 nostr links not rendering in markdown content #3428
Conversation
MarkdownUI doesn't natively understand the nostr: URI scheme, causing nprofile/npub/note/nevent/naddr links to render as plain text in longform articles (kind 30023). This adds preprocessing that converts nostr entities into markdown link syntax before passing to MarkdownUI: - nostr:nprofile1... → [@DisplayName](damus:nostr:nprofile1...) - nostr:npub1... → [@DisplayName](damus:nostr:npub1...) - nostr:note1... → [@note1abc:xyz](damus:nostr:note1...) Key implementation details: 1. preprocessNostrLinksInMarkdown() runs two regex passes: - First pass: converts nostr:-prefixed URIs (nostr:npub1...) - Second pass: converts bare bech32 entities (npub1...) Negative lookbehinds prevent double-processing existing links. 2. getNostrLinkDisplayString() determines display text: - For npub/nprofile: looks up profile name, falls back to abbreviated bech32 (e.g., @npub1abc:xyz) when not cached - For note/nevent/naddr: always uses abbreviated bech32 3. getProfileDisplayNameIfFound() helper returns nil when profile isn't cached, allowing callers to fall back to bech32 format. 4. Updated mention_str() to use the same fallback logic for consistency between kind1 notes and longform content. This matches the behavior of kind1 notes where users can paste bare npub/nprofile identifiers and they're automatically rendered as clickable profile mentions. Closes: damus-io#3426 Changelog-Fixed: Fixed NIP-19 nostr links (nprofile, npub, note, nevent) not rendering in longform content Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
before PR
after PR
|
danieldaquino
added
the
pr-in-queue
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Warning Rate limit exceeded@alltheseas has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
Comment |
2 participants
Summary
nostr:prefixed URIs and bare bech32 entities for consistency with kind1 notesChecklist
Standard PR Checklist
- [x] My PR is either small, or I have split it into smaller logical commits that are easier to review
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 15 Pro (Simulator)
iOS: 18.0
Damus: Current master + this PR
Setup: Longform article containing nprofile, npub, note, and nevent mentions both with and without nostr: prefix
Steps:
xcodebuild test -scheme damus -destination 'platform=iOS Simulator,name=iPhone 15 Pro'Results:
Other notes
This fix addresses issue #3426 where nostr:nprofile links in longform articles were rendering as plain text instead of clickable mentions.
The implementation preprocesses markdown content before passing to MarkdownUI, converting nostr entities into standard markdown link syntax that MarkdownUI can render. Profile display names are looked up from the cache, with a fallback to abbreviated bech32 format (e.g.,
@npub1abc:xyz) when the profile isn't available.🤖 Generated with Claude Code