Fix overlay issue on short replies #3446
Open
+45
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outer check (bar.is_empty) and inner check (has_any_action) could disagree, causing an empty styled container to appear. For example, bar.is_empty includes relays in its check, but relays don't produce a visible button - resulting in a styled "dot" with nothing inside. Add should_show_action_bar that mirrors EventActionBar's has_any_action logic, ensuring both checks agree on when to render the action bar. Signed-off-by: alltheseas <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The action bar used .padding(.vertical, -20) which pulled it UP into the chat bubble, causing it to overlap message text on short replies. Replace with .offset(y: 15) to push the bar BELOW the bubble edge, ensuring the overlay never covers the message content. Closes: damus-io#3445 Signed-off-by: alltheseas <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
danieldaquino
added
the
pr-in-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
has_any_actionlogic to prevent empty styled containers ("dots") from appearing.padding(.vertical, -20)with.offset(y: 15)to push the action bar below the bubble instead of pulling it up into the contentTest plan
Closes: #3445
🤖 Generated with Claude Code