fix: repost notifications not appearing in notifications tab #3448
+230
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repost deduplication logic was incorrectly placed before the context switch in handle_text_event(), causing notification events to be filtered out when the same note had already been reposted in the home feed. This fix moves the dedup logic inside the .home case where it belongs. Notifications should always show reposts of YOUR posts, even if the same note was already reposted by someone else in your home feed. Root cause: commit bed4e00 added home feed dedup but placed the logic before the context switch, affecting all contexts instead of just home. Note on nostrdb: This bug is purely in application routing logic and does not require database-level changes. The existing nostrdb TODO (about inner event validation) is unrelated to this notification issue. Changelog-Fixed: Fixed repost notifications not appearing in notifications tab Closes damus-io#3165 Signed-off-by: alltheseas
Adds comprehensive tests to prevent regression of issue damus-io#3165 where repost notifications were incorrectly blocked by home feed deduplication. Tests cover: - Regression test: notifications not blocked by home dedup (main fix) - Home feed deduplication still works correctly - Dedup tracks inner event ID, not repost event ID - Context isolation (.other context doesn't affect dedup) Each test documents the expected behavior and provides clear failure messages to aid debugging if the bug reoccurs. Signed-off-by: alltheseas
alltheseas
added
bug
danieldaquino
added
the
pr-in-queue
Collaborator
|
thanks! i merged this into my staging branch |
jb55
added a commit
that referenced
this pull request
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes repost notifications not appearing in the notifications tab. The root cause was that the home feed deduplication logic for reposts was incorrectly placed before the context switch in
handle_text_event(), causing notification events to be filtered out when the same note had already been reposted in the home feed.This fix moves the dedup logic inside the
.homecase where it belongs. Notifications should always show reposts of YOUR posts, even if the same note was already reposted by someone else in your home feed.Changes
.homeswitch case with guard clause (nevernesting pattern)Checklist
Standard PR Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 17 Pro Simulator
iOS: iOS 26.0
Damus: Commit 3ac9e1b (this PR)
Setup: Test account with reposts of authored notes
Steps:
Results:
screenshot
Other notes
#qfilter implementation).homecaseCloses #3165