fix: (detect) quote notifications (from third-party clients) #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per NIP-18, quote posts use q tags: ["q", "<event-id>", "<relay-url>", "<pubkey>"]. Third-party Nostr clients may only include the q tag without a separate p tag for the quoted note's author. This causes Damus to miss quote notifications because the existing notification filter only uses #p (pubkey) matching. This fix adds quote notification detection by: 1. Loading our quotable note IDs from nostrdb at startup (text, longform, highlight) 2. Adding a second notification filter using #q with our note IDs 3. Updating handle_notification() to accept events that either: - Reference our pubkey in a p tag (existing behavior) - OR quote one of our notes via a q tag (new behavior) 4. Tracking new notes we post during the session 5. Refreshing the notification subscription (debounced) when we post new notes so quotes of newly posted notes are also detected Key implementation details: - quotableKinds: Defines which event kinds can be quoted (text, longform, highlight) - subscribe_to_notifications(): Extracted method that can be called to refresh the subscription when our note IDs change - notifications_resub_debouncer: Prevents excessive resubscription when posting multiple notes in quick succession - our_note_ids_order: Tracks insertion order for FIFO eviction when cap exceeded - maxOurNoteIds: Caps set at 1000 to prevent unbounded growth during long sessions The implementation uses nevernesting with guard clauses for clean control flow. Changelog-Fixed: Fixed missing quote notifications from third-party clients Closes damus-io#3447 Closes damus-io#3449 Closes damus-io#3450 Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds QuoteNotificationTests.swift with 5 tests to verify: 1. testEventHasOurPubkey - Standard p-tag detection still works 2. testEventDoesNotHaveOurPubkey - Events without our pubkey are rejected 3. testQuoteEventReferencesOurNote - Quote events with q-tag are detected 4. testQuoteEventDoesNotReferenceOurNote - Unrelated quotes are rejected 5. testCombinedNotificationRelevanceCheck - Both p-tag and q-tag paths work These tests ensure the quote notification fix works correctly and prevents regression. The tests verify the core validation logic that determines whether an event is relevant as a notification. Note: These tests cover the event validation helpers (event_has_our_pubkey, referenced_quote_ids) but not the subscription wiring (subscribe_to_notifications). Integration testing of subscription refresh would require a more complex test harness with mock network components. Closes damus-io#3447 Closes damus-io#3449 Closes damus-io#3450 Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
alltheseas
changed the title
danieldaquino
added
the
pr-in-queue
alltheseas
force-pushed
the
fix/quote-notifications
branch
from
bb70c24 to
4085b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per NIP-18, quote posts use q tags:
["q", "<event-id>", "<relay-url>", "<pubkey>"]. Third-party Nostr clients may only include the q tag without a separate p tag for the quoted note's author. This causes Damus to miss quote notifications because the existing notification filter only uses#p(pubkey) matching.This fix adds quote notification detection by:
#qwith our note IDshandle_notification()to accept events that either reference our pubkey OR quote one of our notesChecklist
Standard PR Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 17 Pro Simulator
iOS: iOS 26
Damus: Commit 4085b5a
Setup: Test account configured with existing posts that can be quoted
Steps:
QuoteNotificationTests(5 tests)Results:
Screenshots
Other notes
This PR also includes 5 regression tests in
QuoteNotificationTests.swiftcovering:Closes #3447
Closes #3449
Closes #3450