Fix longform note URLs not opening from nevent references #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clicking nevent links pointing to longform notes (kind 30023) showed "Can't display note" error because .longform was listed as an unsupported kind in LoadableNostrEventView. This fix adds .longform to the supported kinds alongside .text and .highlight, routing them to ThreadModel for proper display. Closes: damus-io#3003 Closes: damus-io#3485 Changelog-Fixed: Longform article links now open correctly when shared as nevent URLs Signed-off-by: alltheseas <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
alltheseas
added
bug
danieldaquino
added
the
pr-in-queue
Collaborator
|
lgtm |
jb55
added
pr-in-merge-queue
jb55
pushed a commit
to jb55/damus
that referenced
this pull request
Jan 6, 2026
Previously, clicking nevent links pointing to longform notes (kind 30023) showed "Can't display note" error because .longform was listed as an unsupported kind in LoadableNostrEventView. This fix adds .longform to the supported kinds alongside .text and .highlight, routing them to ThreadModel for proper display. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes: damus-io#3487 Closes: damus-io#3003 Closes: damus-io#3485 Changelog-Fixed: Longform article links now open correctly when shared as nevent URLs Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: alltheseas <[email protected]> Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for longform article links (nevent URLs) showing "Can't display note" error instead of opening the article.
Previously, clicking nevent links pointing to longform notes (kind 30023) showed "Can't display note. We do not yet support viewing this type of content." This was because
.longformwas listed as an unsupported kind inLoadableNostrEventView.This fix adds
.longformto the supported kinds alongside.textand.highlight, routing them toThreadModelfor proper display.Checklist
Standard PR Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 17 Pro Simulator
iOS: 26.2
Damus: Commit f4bee9c
Setup: Fresh build from fix branch, logged in with test account
Steps:
Results:
Other notes
Closes: #3003
Closes: #3485
🤖 Generated with Claude Code