Custom filters #79
Merged
Custom filters #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some helpers for adding custom filtering logic to nostr filters. These are just a callback and a closure. There can only be one custom callback filter per filter. Fixes: #33 Signed-off-by: William Casarin <[email protected]>
Closed
Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "custom filter" functionality to ndb_filter. This allows you to include a custom callback function in a filter to add any custom filtering logic you want
Motivation
Sometimes there is lots of data to scan through that has tags with a specific structure. For example, you might want to pull only root kind 1 threads. There is no concept of "negative queries" in nostr, where you look for the absence of some fields. Custom queries allows you to perform additional logic on the query to exclude things like kind1 thread replies.
See
only_threads_filterintest.cfor an example