Thread improvements #1160
Open
Thread improvements #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kernelkind
commented
Oct 10, 2025
kernelkind
commented
- make scroll position go to the correct offset after navigating to a thread
- make scroll position go to the correct offset after all ancestors are loaded
- auto unfold thread if there is only one reply, while retaining original scroll offset
didn't work for threads that have never been open Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
in preparation for thread auto unfolding Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
threads would flicker on receiving new notes when auto scroll is enabled. This is because auto scroll is doing the same actions a user would be doing, which creates children ThreadNodes. These new children have an empty virtual list when they are created for the first time. Since it's a new list, there isn't a last width set, so the flicker gets triggered if hide_on_resize is enabled. The easiest solution is to simply disable hide_on_resize. The flicker isn't very noticable to me, but if this isn't acceptable we can propagate the width to the child nodes (and corresponding lists) so we could still use the hide_on_resize but not hide on every thread open. This flicker was actually happening every time we opened a thread or reply for the first time, but it wasn't noticible because we would always be navigating while it happens Signed-off-by: kernelkind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.