Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur media from unfollowed #779

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Conversation

kernelkind
Copy link
Member

closes #679

@jb55
Copy link
Contributor

jb55 commented Mar 13, 2025

looks like it needs rebase ?

@kernelkind
Copy link
Member Author

rebased with master

@kernelkind
Copy link
Member Author

rebased with master

@kernelkind kernelkind force-pushed the deck-467 branch 2 times, most recently from fb49685 to 09a6065 Compare March 19, 2025 22:00
@kernelkind
Copy link
Member Author

I think it makes more sense to put the promise inside the Job

@kernelkind kernelkind marked this pull request as draft March 19, 2025 22:17
@kernelkind
Copy link
Member Author

I'm going to make this a draft until I'm satisfied with Jobs

@kernelkind kernelkind force-pushed the deck-467 branch 2 times, most recently from 341210b to 4ac7729 Compare March 20, 2025 19:59
@kernelkind kernelkind mentioned this pull request Mar 21, 2025
Closed
@kernelkind kernelkind marked this pull request as ready for review March 21, 2025 00:07
@kernelkind kernelkind mentioned this pull request Mar 21, 2025
@kernelkind kernelkind marked this pull request as draft March 21, 2025 20:37
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jb55
Copy link
Contributor

jb55 commented Mar 22, 2025

needs rebase

Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what the point of the jobs thing is, this seems like its more of an image cache thing? I don't think we should be exposing it to all of our notedeck app interfaces either (AppContext, etc)

@kernelkind kernelkind force-pushed the deck-467 branch 2 times, most recently from 632894f to 4fcdc0c Compare March 22, 2025 04:02
@kernelkind
Copy link
Member Author

I'm not entirely sure what the point of the jobs thing is, this seems like its more of an image cache thing? I don't think we should be exposing it to all of our notedeck app interfaces either (AppContext, etc)

Take another look at it, now it accepts an async closure and does not copy unless needed to call the closure. Also, it limits the amount of concurrently running threads, defaulted to 10.

And yeah on second thought it would probably make more sense moving it into Damus instead of Notedeck.

Let me know what you think

@kernelkind kernelkind marked this pull request as ready for review March 22, 2025 04:18
@kernelkind kernelkind requested a review from jb55 March 22, 2025 04:18
@kernelkind
Copy link
Member Author

rebased with master

@jb55
Copy link
Contributor

jb55 commented Mar 23, 2025

unfortunately trust_media_from_pk2 is just way too slow without the author_kind query plan implementation , as I suspected:

Mar23-115717

Mar23-120029

I will quickly implement that in nostrdb and see if it fixes this

@jb55
Copy link
Contributor

jb55 commented Mar 23, 2025

its faster but still pretty slow. We'll need to update it to only call trust_media_from_pk2 if there is media.

@kernelkind
Copy link
Member Author

moved Jobs into Damus

@kernelkind
Copy link
Member Author

rebased with master

Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
a bounded thread pool

Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
@kernelkind kernelkind marked this pull request as draft March 24, 2025 03:10
@kernelkind kernelkind mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blurhash Blur images from people I dont follow
2 participants