-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blur media from unfollowed #779
base: master
Are you sure you want to change the base?
Conversation
looks like it needs rebase ? |
rebased with master |
rebased with master |
fb49685
to
09a6065
Compare
I think it makes more sense to put the promise inside the |
I'm going to make this a draft until I'm satisfied with |
341210b
to
4ac7729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
needs rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure what the point of the jobs thing is, this seems like its more of an image cache thing? I don't think we should be exposing it to all of our notedeck app interfaces either (AppContext, etc)
632894f
to
4fcdc0c
Compare
Take another look at it, now it accepts an async closure and does not copy unless needed to call the closure. Also, it limits the amount of concurrently running threads, defaulted to 10. And yeah on second thought it would probably make more sense moving it into Let me know what you think |
rebased with master |
its faster but still pretty slow. We'll need to update it to only call trust_media_from_pk2 if there is media. |
moved |
rebased with master |
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
a bounded thread pool Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
closes #679