-
Notifications
You must be signed in to change notification settings - Fork 14
Non-iOS Purple checkout flows (client-side) #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae98be4
to
6c55e5a
Compare
This commit refactors the Purple checkout code, as well as some other blocks, splitting them into smaller modules that that are more reusable and far easier to work with. Signed-off-by: Daniel D’Aquino <[email protected]>
This commit adds a tab component, in preparation for OTP support on the purple checkout page. It adds the radix UI tab component as a dependency, and defines our own tab component with a custom style. Signed-off-by: Daniel D’Aquino <[email protected]>
ac66ebb
to
1a1b8f2
Compare
This commit adds an OTP-via-Nostr-DM authentication method to the Purple checkout page. Now users can choose between the two authentication methods. Signed-off-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
This commit includes several updates and improves to the website navigation: 1. Obsolete TestFlight links were removed and replaced with Notedeck links 2. The Purple page was updated to detect whether the user is logged in or not, and then provide more useful login/signup/see account actions 3. Made the CTA on the top menu customizable, and changed the top menu CTA on the purple and notedeck pages for something more relevant to those pages. Signed-off-by: Daniel D’Aquino <[email protected]>
This commit improves the stability when refreshing the checkout page. More specifically, it avoids an issue where the person has selected Damus iOS as their selected auth method, but then refreshes the page after verifying their npub. Previously the final step would not be aware of their auth method, so it would try to proceed on the web, but a lack of session token would cause issues on the welcome step. This commit addresses this by checking the login status at the last step. If the user selected the OTP auth method, they will necessarily be logged in already. If the user is not logged in, they cannot proceed through the website. Signed-off-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
This commit improves the website build process by using `trailingSlash` in `next.config.js` instead of manually adding symbolic links during the build script. It also adds the option to create a development build with user-configurable environment via an `.env` file Signed-off-by: Daniel D’Aquino <[email protected]>
1a1b8f2
to
1b6209a
Compare
9 tasks
@jb55 quick note before we publish this website version. I think some of the changes you made to the notedeck page have not been pushed, they don't seem to be present in github. You may want to push those changes upstream from where you made them to avoid losing them. |
@jb55 please let me know if you have any questions or concerns with this PR, thanks! |
On Fri, Oct 18, 2024 at 11:13:08AM -0700, Daniel D’Aquino wrote:
@jb55 quick note before we publish this website version. I think some of the changes you made to the notedeck page have not been pushed, they don't seem to be present in github. You may want to push those changes upstream from where you made them to avoid losing them.
the changes were minimal, I don't mind losing them. I can't find the
changes
|
On Fri, Oct 18, 2024 at 11:13:54AM -0700, Daniel D’Aquino wrote:
@jb55 please let me know if you have any questions or concerns with this PR, thanks!
let's merge it!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following:
Checklist
Closes:
orFixes:
tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches — I have not added this because the issue also depends on Non-iOS Purple checkout flows (server-side) api#11Test report
Damus: 1.10.1 (1)
f92509fd
Device: iPhone 13 mini
iOS: 18.0
Browser: Multiple browsers, see steps for details
damus-api:
03e1e90cffd370252826ccb2934320f120b15426
with Node v22.9.0- Note: This was a WIP version of
8bdbd179536da01c3a74b1c8cb5cd7427437c672
that is identical in almost every way except the LN node connection params, which had been changed during development to work with node.js v22.9.0, but has now been reverted for node v18 LTS compatibility. A supplemental test report is attached below to cover the invalidated portion of the testdamus-website:
1b6209afc40c463a04d7267a155e840736301c39
LN wallet: coinos.io
Setup:
python3 -m http.server
) using a development build with our custom test env details (npm run build-dev
)Steps:
Results:
Supplemental test report
This supplemental test report is needed to cover a portion of the previous test that was invalidated due to a small code change on the server-side.
Damus: 1.10.1 (1)
f92509fd
Device: iPhone 13 mini
iOS: 18.0
Browser: Safari
damus-api:
8bdbd179536da01c3a74b1c8cb5cd7427437c672
with Node v18.20.4, running on NixOSdamus-website:
1b6209afc40c463a04d7267a155e840736301c39
LN wallet: coinos.io
Setup:
Steps:
Results:
Other notes
These changes rely on some API changes on the server side. The backend should be updated first when deploying: damus-io/api#11