Open
Conversation
This opens a pull request when a new release happens in the mozilla-services/syncserver-rs repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This opens a pull request when a new release happens in the mozilla-services/syncserver-rs repo.
There are a few things that you might want to change before accepting this.
First, it creates a new file in the repository to track upstream releases. Currently this is set as "syncstorage-rs-release-version" which you may want to change to something else, or stick it in a subdirectory so it doesn't clutter up the root directory.
The second thing is that the Dockerfile currently builds from a specific commit that is hardcoded. In order to make this automatically build the correct release the Dockerfile would need to be modified to read the git version from the $RELEASE_FILE, or the publish-docker.yaml workflow would need to be updated to send the GIT_COMMIT argument into the docker build using whatever is in the $RELEASE_FILE. Since there are multiple approaches to this and I don't know what you prefer, I just left it alone.