Add options for database string and use it for sockets #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use your script with a unix socket to connect to mariadb. Most stuff works, but to create the correct tables for the databases I needed to adapt a few things.
Instead of only extracting the unix_socket string, I decided to make it more logical by extracting all options of the mysql:// string and then only use the unix_socket right now. But if in the future one wants to e.g. also accept ssl connections this would now be an easy change.
What I don't like is copying the database-command, so if you have a better idea please feel free to adapt it.
If you don't want to support this usecase this is also fine, then just close it, at least next time somebody wants to do it they can find this PR and see how it could be done.
I tested that change with tcp connection and unix_socket connection and both work fine now.