Skip to content

use non-root copy if possible #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwarDu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use non-root copy if possible #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/activate_pyzshcomplete
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/python3

import os
from os.path import join, dirname, expanduser
from os import remove, geteuid, walk
from subprocess import run, Popen, PIPE
Expand Down Expand Up @@ -52,7 +53,7 @@ def find_completion_script_dir():
def copy_completion_scripts(target_dir):
print('Copying completion scripts... ')
scripts = get_completion_scripts()
perform_copy_as_root(scripts, target_dir)
perform_copy(scripts, target_dir, not os.access(target_dir, os.W_OK))


def remove_completion_system_cache_files():
Expand Down Expand Up @@ -83,8 +84,8 @@ def get_completion_scripts():
return ' '.join(glob(join(zsh_scripts_dir, '*')))


def perform_copy_as_root(source, target):
commandline = 'sudo cp {} {}'.format(source, target)
def perform_copy(source, target, as_root = False):
commandline = f'{"sudo " if as_root else "" }cp {source} {target}'
if run(commandline.split()).returncode != 0:
raise RuntimeError('Failed copying zsh completion scripts. Make sure '
'to provide root access, as these files are copied '
Expand Down