Switch staging back to builtin oauth Application
#2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the staging environment back to using the builtin `Application` model for OAuth2 authentication, while enabling the `ALLOW_URI_WILDCARDS` setting to allow for wildcard URIs to support Netlify deploy previews.
|
This will temporarily break logins on staging until we go in and set the redirect URLs and other settings again, correct? |
Right. We'll have to create an |
jjnesbitt
approved these changes
Apr 18, 2025
This was referenced Apr 18, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2319
This commit switches the staging environment back to using the builtin
Applicationmodel for OAuth2 authentication, while enabling theALLOW_URI_WILDCARDSsetting to allow for wildcard URIs to support Netlify deploy previews.To be extra cautious, I did not remove the custom
StagingApplicationmodel yet. I think we should merge this, verify it works properly, and only then remove the custom model.