Skip to content

Convert StagingApplication to a proxy model #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

jjnesbitt
Copy link
Member

This switches the StagingApplication model to be a django proxy model. This means that any future oauth2_provider migrations would be applied on the standard application model, and would make moving away from the StagingApplication model altogether much more seamless in the future.

@mvandenburgh
Copy link
Member

@jjnesbitt rebasing should fix the CI failures here (see #2341)

@jjnesbitt jjnesbitt force-pushed the proxy-staging-application branch from d9ac960 to d38100a Compare April 21, 2025 18:26
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll want to keep track of the current StagingApplication in the DB so we can recreate it, as it will get deleted when the migration runs.

@mvandenburgh mvandenburgh added the internal Changes only affect the internal API label Apr 21, 2025
@jjnesbitt
Copy link
Member Author

LGTM. We'll want to keep track of the current StagingApplication in the DB so we can recreate it, as it will get deleted when the migration runs.

That's true, although I think we essentially did that on staging the other day when attempting to complete #2331. Still we should ensure we have a copy of that data prior to merging.

@jjnesbitt jjnesbitt merged commit f8bbd24 into master Apr 24, 2025
10 checks passed
@jjnesbitt jjnesbitt deleted the proxy-staging-application branch April 24, 2025 20:35
@jjnesbitt jjnesbitt added skip-release do not use, only for https://github.com/dandi/dandi-archive/pull/1426 and removed internal Changes only affect the internal API labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release do not use, only for https://github.com/dandi/dandi-archive/pull/1426
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants