Skip to content

🐛 Link newly created accessibility object to existing one while ensuring ancestor tree #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CedricMtta wants to merge 1 commit into
base: open-dev-v1
Choose a base branch
from
Open

🐛 Link newly created accessibility object to existing one while ensuring ancestor tree #920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...htmltopdf-pdfbox/src/main/java/com/openhtmltopdf/pdfboxout/PdfBoxAccessibilityHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,9 @@ private COSDictionary createMarkedContentDictionary() {

private void ensureAncestorTree(AbstractTreeItem child, Box parent) {
// Walk up the ancestor tree making sure they all have accessibility objects.
boolean newAccessibilityObjectCreated=false;
while (parent != null && parent.getAccessibilityObject() == null) {
newAccessibilityObjectCreated=true;
AbstractStructualElement parentItem = createStructureItem(null, parent);
parent.setAccessiblityObject(parentItem);

Expand All @@ -923,6 +925,11 @@ private void ensureAncestorTree(AbstractTreeItem child, Box parent) {
child = parentItem;
parent = parent.getParent();
}
if(newAccessibilityObjectCreated) {
AbstractStructualElement alreadyExistingAccessibilityObject = (AbstractStructualElement) parent.getAccessibilityObject();
child.parent = alreadyExistingAccessibilityObject;
alreadyExistingAccessibilityObject.addChild(child);
}
}

private AbstractStructualElement createStructureItem(StructureType type, Box box) {
Expand Down