Fixed the default commodity_info bug#6
Open
iStrike7 wants to merge 1 commit into
Open
Conversation
…an input to the extrinsic call. This approach was taken to fix the bug with minimal changes to the underlying logic, and is hence not an ideal solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the pallet's "src/lib.rs" where the "nft::UniqueAssets" trait is implemented, both the burn and the transfer methods have a bug.
The problem is that when creating an instance of the tuple representing the commodity (lines 271 & 302) to be used for searching the storage, the default value is used, i.e., "<T as Trait>::CommodityInfo::default()". Due to this when ever the burn or transfer methods are called the search fails with a panic. This bug is not caught by the tests, as the tests themselves use default values.
This bug was fixed by adding the commodity_info as an input to the extrinsic call. This approach was taken to fix the bug with minimal changes to the underlying logic, and is hence not an ideal solution.