-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support files being ignored by babel configuration #1476
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6b54378
support files ignored by babel
3f5a377
cater for unexpected linting in ci?
3f3aee7
empty commit to re-start ci
89e6d3e
revert update of package version, assumed this will be resolved durin…
feebb91
lint
c9cce8d
restore es6 object format (did the lint change this??)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,13 +2,15 @@ jest.mock("fs", () => ({ | |
readFileSync: jest.fn(), | ||
realpathSync: {}, | ||
existsSync: jest.fn(), | ||
statSync: jest.fn(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. N.B. These are needed to prevent an early-return within babel. |
||
stat: jest.fn(), | ||
})) | ||
jest.mock("path", () => { | ||
const path = jest.requireActual("path") | ||
return { ...path, resolve: jest.fn(path.resolve) } | ||
}) | ||
|
||
import { typescriptify, lookupTSConfig, dirContains } from "../transpiler" | ||
import { typescriptify, lookupTSConfig, dirContains, babelify } from "../transpiler" | ||
import * as fs from "fs" | ||
import * as path from "path" | ||
|
||
|
@@ -87,3 +89,25 @@ describe("dirContains", () => { | |
}) | ||
} | ||
}) | ||
|
||
describe("babelify", () => { | ||
it("does not throw when a filepath is ignored due to babel options, and should return the content unchanged", () => { | ||
const dangerfile = `import { a } from 'lodash'; | ||
a();` | ||
|
||
const existsSyncMock = fs.existsSync as jest.Mock | ||
const actualFs = jest.requireActual("fs") as typeof fs | ||
existsSyncMock.mockImplementation((path) => path === "/a/b/babel.config.js" || actualFs.existsSync(path)) | ||
jest.mock( | ||
"/a/b/babel.config.js", | ||
() => { | ||
return { ignore: ["/a/b"] } | ||
}, | ||
{ virtual: true } | ||
) | ||
const act = () => babelify(dangerfile, "a/b/", []) | ||
|
||
expect(act).not.toThrow() | ||
expect(act()).toEqual(dangerfile) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. This was produced when running
yarn lint
- unclear why previous PRs did not produce the same? But without this, the CI fails.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, weird!