Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Draft PR support #261

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Add Draft PR support #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa0b33
feat(multiplatform): add mingw runner
Vacxe Feb 6, 2024
73bd8d1
feat(kotlin): add draft field to Pull request
Vacxe Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/github/GitHub.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ data class GitHubPR(
val head: GitHubMergeRef,
val base: GitHubMergeRef,
val state: GitHubPullRequestState,
@SerialName("draft") val isDraft: Boolean,
@SerialName("locked") val isLocked: Boolean,
@SerialName("merged") val isMerged: Boolean?,
@SerialName("commits") val commitCount: Int?,
Expand Down
1 change: 1 addition & 0 deletions ...-kotlin-library/src/test/kotlin/systems/danger/kotlin/models/github/GitHubParsingTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class GitHubParsingTests {
assertEquals(1471447574000, mergedAt?.toEpochMilliseconds())
assertEquals(false, isLocked)
assertEquals(true, isMerged)
assertEquals(false, isDraft)
assertEquals(15, commitCount)
assertEquals(8, commentCount)
assertEquals(11, reviewCommentCount)
Expand Down
1 change: 1 addition & 0 deletions danger-kotlin-library/src/test/resources/githubDangerJSON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@
"issue_url": "https://api.github.com/repos/artsy/eidolon/issues/609",
"number": 609,
"state": "closed",
"draft": false,
"locked": false,
"title": "Xcode updates",
"user": {
Expand Down
1 change: 1 addition & 0 deletions danger-kotlin-library/src/test/resources/githubWithClosedMilestoneDangerJSON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@
"issue_url": "https://api.github.com/repos/artsy/eidolon/issues/609",
"number": 609,
"state": "closed",
"draft": false
"locked": false,
"title": "Xcode updates",
"user": {
Expand Down
1 change: 1 addition & 0 deletions danger-kotlin-library/src/test/resources/githubWithSomeNullsAttributeDangerJSON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@
"issue_url": "https://api.github.com/repos/artsy/eidolon/issues/609",
"number": 609,
"state": "closed",
"draft": false,
"locked": false,
"title": "Xcode updates",
"user": {
Expand Down
1 change: 1 addition & 0 deletions danger-kotlin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ kotlin {
"Mac OS X" -> macosX64("runner")
"Linux" -> linuxX64("runner")
"Mac OS X Apple silicon" -> macosArm64("runner")
"Windows 11" -> mingwX64("runner")
else -> throw GradleException("Host OS '$hostOs' is not supported.") as Throwable
}

Expand Down
Loading