Skip to content

Conversation

@danh121097
Copy link
Owner

No description provided.

danhnguyen added 26 commits July 10, 2025 23:05
- Set base URL to '/' for Vercel deployment
- Simplified theme imports to use default VitePress theme properly
- Added cssCodeSplit: false to ensure CSS is bundled correctly
- Updated Vercel config with proper caching headers
- Removed manual CSS imports that were causing conflicts
…apLibre GL

- Introduced a new section on markers, covering basic, draggable, multiple markers, markers with popups, and dynamic markers.
- Added examples demonstrating how to create and customize markers, including event handling and styling.
- Created a guide on basic usage of Vue MapLibre GL components, including map creation, data sources, markers, popups, and using composables.
- Expanded configuration documentation detailing map options, component settings, and environment configurations for development and production.
…for improved performance

feat: Enhance Mapbox component with sensible default options and optimized computed properties

refactor: Simplify and streamline useLayerEventListener and useMapEventListener for better efficiency

refactor: Update useCreateMapbox to simplify camera controls and remove unnecessary methods

chore: Add useDebounce and useOptimizedComputed utilities for better performance and reactivity

fix: Improve Vite configuration for better build optimization and dependency management

docs: Update package.json for better type definitions and module exports
🎨 style: import CSS styles in index.ts and configure asset file naming in vite.config.ts
♻️ chore: update package version to 3.2.2 in package.json and yarn.lock
… and enhance image handling with force recreation option
Copilot AI review requested due to automatic review settings November 25, 2025 04:32
@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vue-mapbox-gl Ready Ready Preview Comment Nov 25, 2025 4:33am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package from version 2.1.40 to 3.2.5, representing a major version upgrade. The changes refactor the codebase to a more modular architecture with improved composables, enhanced type definitions, and updated dependencies.

  • Major version upgrade from 2.x to 3.x with breaking changes in package structure and exports
  • Complete refactor of composables with enhanced error handling, debugging capabilities, and performance optimizations
  • Reorganized file structure with separation of concerns (composables, types, enums, helpers)

Reviewed changes

Copilot reviewed 107 out of 143 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Major version bump to 3.2.5, package renamed to vue3-maplibre-gl, updated dependencies including maplibre-gl ^5.6.1
libs/types/index.ts New comprehensive type definitions for MapLibre GL integration with Vue 3
libs/style.css New CSS file importing MapLibre GL styles
libs/index.ts New main entry point with re-exports of composables, enums, helpers, types, and MapLibre GL classes
libs/helpers/index.ts New helper utilities for ID generation, version checking, and coordinate validation
libs/enums/* New enum definitions for map status, events, and provide keys
libs/composables/utils/* New utility composables for zoom, rotate, pan, bounds, and other map operations
libs/composables/map/* New map management composables with enhanced state tracking and error handling
libs/composables/layers/* New layer creation composables for fill, line, circle, and symbol layers
libs/composables/sources/* New GeoJSON source management composable
libs/composables/event/* New event listener composables for map and layer events
libs/composables/control/* New control composables for geolocate functionality
src/components/GeoControl.vue Removed legacy component
src/App.vue Removed example application file
index.html Updated HTML structure with proper doctype and meta tags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

getCurrentCamera,
validatePanOffset,
panStatus: panStatus.value as Readonly<PanStatus>,
isPanning: isPanning.value,
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The returned panCount property is missing from the return object. The interface PanByActions at line 38 declares panCount: number but it's not included in the return statement. This will cause a runtime error when consumers try to access panCount.

Suggested change
isPanning: isPanning.value,
isPanning: isPanning.value,
panCount: panCount.value,

Copilot uses AI. Check for mistakes.
@danh121097 danh121097 merged commit 28911d0 into main Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants