Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sso.rs
Original file line number Diff line number Diff line change
Expand Up @@ -424,13 +424,13 @@ pub async fn exchange_refresh_token(
Some(TokenWrapper::Refresh(refresh_token)) => {
// Use new refresh_token if returned
let (new_refresh_token, access_token, expires_in) =
Client::exchange_refresh_token(refresh_token.clone()).await?;
Client::exchange_refresh_token(refresh_token).await?;

create_auth_tokens(
device,
user,
client_id,
new_refresh_token.or(Some(refresh_token)),
new_refresh_token,
access_token,
expires_in,
)
Expand Down
18 changes: 13 additions & 5 deletions src/sso_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,19 @@ impl Client {
Ok(token_response) => token_response,
};

Ok((
token_response.refresh_token().map(|token| token.secret().clone()),
token_response.access_token().secret().clone(),
token_response.expires_in(),
))
// Always surface a refresh token:
// - If the IdP (e.g., Authentik) returned a rotated one, use it.
// - Otherwise, keep using the one we just used for this request.
let access = token_response.access_token().secret().clone();
let expires_in = token_response.expires_in();

let new_refresh = token_response
.refresh_token()
.map(|t| t.secret().clone())
.unwrap_or_else(|| rt.secret().clone());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey
Not sure how this change anything since .unwrap_or_else(|| rt.secret().clone()) should be equivalent to new_refresh_token.or(Some(refresh_token)).


Ok((Some(new_refresh), access, expires_in))

}
}

Expand Down
Loading