Skip to content

Conversation

@reneleonhardt
Copy link

Chores

  • MSRV passed the 1.85 threshold, prepare for edition 2024

@reneleonhardt
Copy link
Author

reneleonhardt commented Nov 22, 2025

Notes

@BlackDex
Copy link
Collaborator

I think we do not need any changes on our current code-base at all to switch to the 2024 edition.
No need to replace all if let... with bulky match statements as far as i know.

@reneleonhardt
Copy link
Author

Old code is still valid, but just try cargo fix yourself to see all warnings for changed rules.
https://doc.rust-lang.org/cargo/commands/cargo-fix.html#edition-migration

You can see how much I improved manually to reduce that bulkiness to a minimum, that's not the same code cargo fix generated.

@BlackDex
Copy link
Collaborator

Old code is still valid, but just try cargo fix yourself to see all warnings for changed rules. https://doc.rust-lang.org/cargo/commands/cargo-fix.html#edition-migration

You can see how much I improved manually to reduce that bulkiness to a minimum, that's not the same code cargo fix generated.

There is no need for cargo fix on our current code-base.
With Edition 2024 there are several other items which could be fixed like some if statements which can be merged, this can be seen when you run clippy on the code-base after setting the Edition to 2024.

All other fixes Cargo does automatically are only because it doesn't know if it will break the code or not, and just goes ahead and adjust it to a more safe default, which as far as I can tell, is not needed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants