2026.6.0 send support#7346
Open
Timshel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
2026.6.0the client now start by requiring an access_token.Some remarks:
Added
auth/send.rssince I though thatauth.rswas already long enough.Added the
silentproperty to theErrorto be useErrorKind::Jsonwithout logging the error.Probably could be injected in some place like the
Error::emptybut wanted to keep modifications to a minimum.While adding another set of optional values to
ConnectDataI wondered if it could be converted to anEnumwith a value for eachgrant_type? I think it would be cleaner, but maybe I'm missing something ?