Closed
Conversation
added 3 commits
June 27, 2025 11:57
…damiento local negocio' como nuevo tipo de producto
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to introduce a new product type for "Arrendamiento local negocio".
- Increased the character limit for the "tipo" column in the productos XML from 20 to 50.
- Added a new constant LOCAL_BUSINESS_RENTAL to the ProductType class and updated the list of available product types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Core/Table/productos.xml | Updated the column definition for product type to support longer values. |
| Core/Lib/ProductType.php | Added a new product type constant and included it in the type mapping. |
Comments suppressed due to low confidence (2)
Core/Lib/ProductType.php:30
- [nitpick] Confirm that using Spanish for the constant value is intentional and aligns with the application's localization and labeling conventions.
const LOCAL_BUSINESS_RENTAL = 'Arrendamiento local negocio';
Core/Table/productos.xml:100
- Ensure that this schema change is accompanied by a corresponding database migration to update the column length in production.
<type>character varying(50)</type>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea #3990