Skip to content

Tarea 3990 - Nuevo tipo producto#3

Closed
daniel89fg wants to merge 3 commits intomasterfrom
3990-tipo-producto-rental-business
Closed

Tarea 3990 - Nuevo tipo producto#3
daniel89fg wants to merge 3 commits intomasterfrom
3990-tipo-producto-rental-business

Conversation

@daniel89fg
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings June 27, 2025 11:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to introduce a new product type for "Arrendamiento local negocio".

  • Increased the character limit for the "tipo" column in the productos XML from 20 to 50.
  • Added a new constant LOCAL_BUSINESS_RENTAL to the ProductType class and updated the list of available product types.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Core/Table/productos.xml Updated the column definition for product type to support longer values.
Core/Lib/ProductType.php Added a new product type constant and included it in the type mapping.
Comments suppressed due to low confidence (2)

Core/Lib/ProductType.php:30

  • [nitpick] Confirm that using Spanish for the constant value is intentional and aligns with the application's localization and labeling conventions.
    const LOCAL_BUSINESS_RENTAL = 'Arrendamiento local negocio';

Core/Table/productos.xml:100

  • Ensure that this schema change is accompanied by a corresponding database migration to update the column length in production.
        <type>character varying(50)</type>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants