Skip to content

fix: ajustar el manejo de valores por defecto para campos de fecha y datetime #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel89fg wants to merge 1 commit into from
+2 −2
Closed

fix: ajustar el manejo de valores por defecto para campos de fecha y datetime #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/Template/ModelClass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ public function clear(): void
'tinyint', 'boolean' => in_array($field['default'], ['true', 't', '1'], false),
'integer', 'int' => intval($field['default']),
'decimal', 'double', 'double precision', 'float' => floatval($field['default']),
'date' => Tools::date($field['default']),
'datetime', 'timestamp' => Tools::dateTime($field['default']),
'date' => Tools::date(), // asumimos que el campo fecha nunca tendrá valor por defecto
'datetime', 'timestamp' => Tools::dateTime(), // asumimos que el campo datetime nunca tendrá valor por defecto
Comment on lines +200 to +201
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumption that date/datetime fields never have default values may not hold true for all use cases. Some fields might legitimately need a specific default date (e.g., a system start date, or a far-future date for 'never expires' scenarios). This change breaks backward compatibility if any models rely on database-defined default values for date fields. Consider checking if $field['default'] is empty/null before falling back to the current date, allowing models with explicitly defined defaults to continue working: 'date' => empty($field['default']) ? Tools::date() : Tools::date($field['default'])

Suggested change
'date' => Tools::date(), // asumimos que el campo fecha nunca tendrá valor por defecto
'datetime', 'timestamp' => Tools::dateTime(), // asumimos que el campo datetime nunca tendrá valor por defecto
'date' => empty($field['default']) ? Tools::date() : Tools::date($field['default']),
'datetime', 'timestamp' => empty($field['default']) ? Tools::dateTime() : Tools::dateTime($field['default']),

Copilot uses AI. Check for mistakes.
default => $field['default'],
};
}
Expand Down
Loading