Skip to content

Policy tag support for aws_lakeformation_permissions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 50 commits into
base: f-aws_lakeformation_policy_tag
Choose a base branch
from
Draft

Policy tag support for aws_lakeformation_permissions #1

wants to merge 50 commits into from

Conversation

danielcmessias
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_permissions-tag-support branch 3 times, most recently from e796126 to 5bf3443 Compare June 3, 2021 16:38
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_permissions-tag-support branch from 64a0137 to e42fb36 Compare August 3, 2021 15:23
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_policy_tag branch from 0c681c5 to c0f51dc Compare August 3, 2021 15:34
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_permissions-tag-support branch 2 times, most recently from 255934f to 924eb29 Compare August 3, 2021 15:37
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_policy_tag branch from c0f51dc to 44f82d5 Compare August 13, 2021 12:29
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_policy_tag branch from 44f82d5 to 78e37d0 Compare April 21, 2022 09:55
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_permissions-tag-support branch from 75d7bc5 to 19a63f1 Compare April 21, 2022 10:02
@github-actions github-actions bot added documentation Improvements or additions to documentation service/lakeformation tests size/XL labels Apr 21, 2022
DrFaust92 and others added 14 commits June 5, 2022 20:30
@DrFaust92
add args
2db47e9
@DrFaust92
changelog
a609390
@DrFaust92
add supported_ip_address_types arg
d6578d6
@DrFaust92
add supported_ip_address_types arg
effa1c0
@DrFaust92
changelog
88010e5
@DrFaust92
add to update list
7a23e2f
@DrFaust92
changelog
8f05159
@DrFaust92
Update 25182.txt
5983cc0
@DrFaust92
Update location_efs.go
c82fb12
@DrFaust92
Update location_efs_test.go
63d466b
@ewbankkit
r/aws_vpc_endpoint_service: Start to tidy up resource Create.
37f97ee
@ewbankkit
Add 'FindVPCEndpointServices' and friends.
f942f4c
@ewbankkit
r/aws_vpc_endpoint_service: Tidy up resource Create.
ecfbcea 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCEndpointService_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointService_basic -timeout 180m
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointService_basic
--- PASS: TestAccVPCEndpointService_basic (222.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	227.028s
@ewbankkit
r/aws_vpc_endpoint_service: Tidy up resource Delete.
3b67a5a 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCEndpointService_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointService_basic -timeout 180m
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointService_basic
--- PASS: TestAccVPCEndpointService_basic (220.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	225.331s
ewbankkit and others added 13 commits June 21, 2022 15:28
@ewbankkit
Fix semgrep 'test-config-funcs-correct-form' error.
4229330
@ewbankkit
Merge branch 'main' into HEAD
e18d005
@ewbankkit
Merge pull request hashicorp#25189 from DrFaust92/ec2-endpoint-servic…
1ecdb14 
…e-ip-types

r/vpc_endpoint_service - add `supported_ip_address_types` argument
@ewbankkit
Merge pull request hashicorp#25182 from DrFaust92/datasync-efs-args
d5f0784 
r/datasync_location_efs - add access point args
@ewbankkit
Merge pull request hashicorp#25517 from hashicorp/dependabot/go_modul…
f8abd7a 
…es/github.com/aws/aws-sdk-go-1.44.39

build(deps): bump github.com/aws/aws-sdk-go from 1.44.34 to 1.44.39
@ewbankkit
Merge pull request hashicorp#25518 from hashicorp/dependabot/go_modul…
7032e9f 
…es/providerlint/github.com/aws/aws-sdk-go-1.44.39

build(deps): bump github.com/aws/aws-sdk-go from 1.44.34 to 1.44.39 in /providerlint
Update CHANGELOG.md for hashicorp#25518
f0b32e2
@YakDriver
Merge pull request hashicorp#19523 from danielcmessias/f-aws_lakeform…
0840e1f 
…ation_policy_tag

New resource: aws_lakeformation_lf_tag
@danielcmessias
New resource: aws_lakeformation_policy_tag
6db3626
@danielcmessias
New resource: aws_lakeformation_permissions
aa5fef7
@danielcmessias
Service package refactor
dd0bfbb
@danielcmessias
Adding markdown files
9623efd
@danielcmessias
Adding initial files
25fe426
@danielcmessias danielcmessias force-pushed the f-aws_lakeformation_permissions-tag-support branch from 19a63f1 to 25fe426 Compare June 21, 2022 20:26
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation generators github_actions linter provider repository service/datasync service/ec2 service/lakeformation service/vpc service/vpnclient size/XL tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielcmessias @ewbankkit @DrFaust92 @YakDriver