Remove unused Node.js devcontainer feature#273
Conversation
The project has no JS/TS sources, no package.json, and no scripts that invoke node/npm. The feature was only there to back the claude-code feature, which already self-installs Node if missing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes the Node.js version 24 devcontainer feature from ChangesDevcontainer Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ghcr.io/devcontainers/features/node:1from .devcontainer.json.package.json, and no scripts (setup,develop,lint) that invokenode/npm. The feature existed only to back theclaude-codefeature, which auto-installs Node 18 from NodeSource when it isn't already present (see its install.sh).Test plan
claude --versionworks inside the rebuilt container (claude-code feature installs its own Node).scripts/setup,scripts/develop, andscripts/lintstill run.🤖 Generated with Claude Code
Summary by CodeRabbit