Skip to content

fix issues/70 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix issues/70 #96

wants to merge 1 commit into from

Conversation

tim-tim707
Copy link

Changes are done without understanding most of this plugin. I found a hack to make it work but I'm sure there is a better way to do it that I don't know of.

Explanations of the bug can be found on my message here: #70 (comment)

Maybe the flag on ripgrep is enough and the vim.fs.normalize are only here because my sqlite3 is infected with bad file path ?
Right now, it doesn't work if I don't keep the vim.fs.normalize. Some directories are half normalized and half not, which may come from a data provider I am not aware of.
I haven't fully tested properly my changes, maybe there are data paths that do not go through a normalize call and in that case it could fail like previously

@tim-tim707 tim-tim707 changed the title fix https://github.com/danielfalk/smart-open.nvim/issues/70 fix issues/70 Jan 10, 2025
@tim-tim707
Copy link
Author

I don't know how the default smart-open is supposed to work so I need to test this on linux, but I think this fix breaks the "current directory listing". I opened a new folder for another project but none of the files would show up. require("telescope.builtin").find_files() works fine for this directory though, so I think it is a problem with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant