Skip to content

🐛 fix wrong import and add a sanity check for default deps import #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

🐛 fix wrong import and add a sanity check for default deps import #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,20 @@ jobs:
run: uv python install ${{ matrix.py }} && uv python pin ${{ matrix.py }} && uv venv --python ${{ matrix.py }}
- name: Override ray==${{ matrix.ray }} dagster==${{ matrix.dagster }}
run: uv add --no-sync "ray[all]==${{ matrix.ray }}" "dagster==${{ matrix.dagster }}"
- name: Install dependencies
- name: Install Default Dependencies
run: uv sync
env:
UV_LOCKED: "1"
- name: Check Import With Only Default Dependencies
run: uv run python -c "import dagster_ray"
env:
UV_LOCKED: "1"
- name: Install All Dependencies
run: uv sync --all-extras --dev
- name: Run tests
env:
PYTEST_KUBERAY_VERSIONS: "${{ matrix.kuberay }}"
UV_LOCKED: "1"
run: uv run pytest -v .

lint:
Expand Down
3 changes: 1 addition & 2 deletions src/dagster_ray/kuberay/resources/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
from __future__ import annotations

import re
from abc import abstractmethod
from abc import ABC, abstractmethod

from pydantic import Field, PrivateAttr
from pytest_kubernetes.providers.base import ABC

from dagster_ray._base.constants import DEFAULT_DEPLOYMENT_NAME
from dagster_ray._base.resources import RayResource
Expand Down