Update OpenTelemetry to 1.12.0 and fix breaking API changes #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…breaking changes Co-authored-by: danielgerlag <[email protected]>
…sion 1.12.0 Co-authored-by: danielgerlag <[email protected]>
Copilot
AI
changed the title
[WIP] Update OpenTelemetry to 1.12.0 in all projects in this repo. Fix any breaking API changes and test it all works.
Update OpenTelemetry to 1.12.0 and fix breaking API changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates OpenTelemetry.Api from version 1.1.0 to 1.12.0 across all projects in the repository and fixes the breaking API changes introduced in the newer version.
Changes Made
Package Updates
OpenTelemetry.Apifrom 1.1.0 to 1.12.0System.Diagnostics.DiagnosticSourcefrom 6.0.0 to 9.0.0 (required dependency for OpenTelemetry 1.12.0)Breaking API Changes Fixed
The OpenTelemetry 1.12.0 release deprecated several extension methods and moved functionality to the core
Activityclass:ActivityExtensions.RecordException()with the newActivity.AddException()methodActivityExtensions.SetStatus(Status.Error)to use the simplerActivity.SetStatus(ActivityStatusCode.Error)and removed duplicate callsFiles Modified
src/WorkflowCore/WorkflowCore.csproj- Package reference updatessrc/WorkflowCore/Services/WorkflowActivity.cs- Fixed SetStatus API usagesrc/WorkflowCore/Services/WorkflowHost.cs- Updated exception recordingsrc/WorkflowCore/Services/BackgroundTasks/QueueConsumer.cs- Updated exception recording (2 locations)src/WorkflowCore/Services/BackgroundTasks/RunnablePoller.cs- Updated exception recording (4 locations)Testing
Benefits
The update ensures WorkflowCore stays current with OpenTelemetry best practices while maintaining all existing observability functionality.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.