fix: support defaults for custom JSON wrappers - #1078
Open
deepakganesh78 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemaProviderdefaults in their declared JSON Schema wire formatjson.UnmarshalercontractRoot cause
Default tags were reflect-converted directly from the schema value to the Go field type. A custom schema can expose a primitive wire type while using a struct wrapper in Go, so the primitive value is not directly convertible to the wrapper.
Tests
go test . -run '^(TestSchema|TestFeatures)$' -count=1go test . -count=1go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 runThe full Windows suite was also attempted; unrelated platform-sensitive
TestCLIShutdownand Fiber adapter tests timed out/failed, while the affected core package and configured lint pass.Fixes #814