fix: override group modifier#819
Closed
fourcels wants to merge 1 commit into
Closed
Conversation
fourcels
commented
May 8, 2025
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
=======================================
Coverage 93.08% 93.09%
=======================================
Files 23 23
Lines 5307 5312 +5
=======================================
+ Hits 4940 4945 +5
Misses 314 314
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| oh(&operation) | ||
| if grp, ok := api.(*Group); ok { | ||
| for _, oh := range operationHandlers { | ||
| grp.UseSimpleModifier(oh) |
Owner
There was a problem hiding this comment.
Doesn't this modify the group for all the other operations that may get registered on it as well? I'm not sure this is the correct behavior.
@fourcels what bug are you trying to fix with this?
Contributor
Author
There was a problem hiding this comment.
router modifier should overrite group modifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.