Skip to content

add getnewargs_ex to Enum, fix pickling #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2025
Merged

add getnewargs_ex to Enum, fix pickling #663

merged 2 commits into from
Mar 30, 2025

Conversation

benedikt-bartscher
Copy link
Contributor

@benedikt-bartscher benedikt-bartscher commented Mar 29, 2025 •
edited
Loading

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review March 29, 2025 01:27
Gobot1234
Gobot1234 reviewed Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, please can you add a regression test that uses this?

@benedikt-bartscher
Copy link
Contributor Author

@Gobot1234 I added a small regression test

@Gobot1234 Gobot1234 merged commit 08e8a68 into danielgtaylor:master Mar 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gobot1234 Gobot1234 Gobot1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedikt-bartscher @Gobot1234