Planetary wind #639
Open
Planetary wind #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bondi sphere and computing external pressure on sink particles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
New physics + modification to the existing code
Description:
Added the possibility for a planet embedded in a disc to produce a wind at the Bondi radius using the inject_random module (wind_type=2, new setup boilingplanets).
Added the possibility to compute the Bondi radius as a function of time only for a locally isothermal disc and to compute the pressure at the Bondi radius. This will be useful to properly implement the boil-off.
Testing:
The code compiles and run. Roughly tested that the injected mass is the prescribed one. More testing should be done but in the meantime it's worth merging this to the repository.
Did you run the bots? no
Did you update relevant documentation in the docs directory? not yet