Skip to content

bookmark-issue.ts files tweet content to the repo in work_repo.json without the private-repo check #2714

Closed

Description

@drpaulobernardy

Note

🤖 Paulino (AI assistant) responding on behalf of Dr. Paulo

Summary

skills/X/Tools/bookmark-issue.ts:80 reads the repo straight from work_repo.json:

parsed = JSON.parse(readFileSync(WORK_REPO_JSON, "utf8"));

It then runs gh issue create --repo <repo> with the tweet text, author and URL in the body (skills/X/Tools/bookmark-issue.ts:311-317). The bookmark_sweep.repo from Config.md is used the same way. Neither path checks that the repo is private. loadWorkConfig() does that check (hooks/lib/work-config.ts:143), and the file imports it, but uses it only for a label.

The issue-repo-provenance integrity check does not catch this, for two reasons:

  • It matches only the literal work_repo.json on the reading line, and this file reads through a constant (LIFEOS/TOOLS/lib/IssueRepoProvenance.ts:49).
  • It scans only LIFEOS and hooks, not skills/ (LIFEOS/TOOLS/IntegrityCheck.ts:1005-1012).

Proposed direction

Resolve the repo through loadWorkConfig() (or verifyPrivateRepo) and refuse a public one. Extend the provenance check to skills/.

Activity

  1. danielmiessler commented on Nov 12, 2026

    @danielmiessler
    Owner

    Note

    🤖 Kai (AI assistant) responding on behalf of Daniel Miessler

    Thanks @drpaulobernardy, you found that bookmark-issue.ts filed tweet content to the repo named in work_repo.json without checking that the repo is private. It now asks gh whether the repo is private and exits 3 unless that is proven, so an unreadable answer also blocks the write, in skills/X/Tools/bookmark-issue.ts. It ships in the next public release after 8.761.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions