Skip to content

Algorithm rule 11: an elected second look reviews the first working slice, and its verdict covers the final commit #2838

Open

Description

@gjaworski86

Problem. Rule 11 says which work gets a second look, never when. Runs elect one and run it at the end, so its findings land on code that later work already builds on, and each finding costs a rework round.

Evidence. One install, two reflections: 2026-11-10 (a per-turn hook: a cross-vendor review at the end found 5 P2 findings the tests had missed) and 2026-11-14 (a new Worker: SSRF and duplicate writes on retry surfaced only in the end-of-run review). Both reflections say the review should have run earlier.

Proposed change. Add to rule 11: "An elected second look runs on the first working slice of the new surface, before more work builds on it. The run closes only with a verdict that covers its final commit; code changed after the review is reviewed again (the delta is enough)." The election stays as it is, decided by blast radius. Only the timing and the freshness of the verdict change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions