Repository navigation
Conversation
isihussain
left a comment
There was a problem hiding this comment.
Code Review: Multi-Axis Evaluation
Thank you @Hoyass for addressing mobile documentation navigation! Prior to this change, DocsLayout rendered a fixed-width horizontal sidebar (w-64 in a flex row) that rendered mobile viewports essentially unreadable or caused horizontal clipping.
1. Responsive Layout & CSS Flexbox Architecture
- Flex Container Direction & Minimum Widths:
- Changing to
flex h-[calc(100vh-3.5rem)] min-w-0 flex-col lg:flex-rowand addingmin-w-0to thechildrenwrapper correctly resolves the CSS flexbox automatic minimum size pitfall where preformatted code blocks or wide tables force flex items to overflow their container.
- Changing to
- Semantic Native Disclosure:
- Using native HTML5
<details>and<summary>for the mobile navigation drawer (lg:hidden) is clean, zero-dependency, and accessible out of the box without requiring external accordion or modal state management libraries.
- Using native HTML5
- Scroll Boundary Isolation: Constraining the mobile sidebar height with
max-h-[60vh]prevents the opened navigation tree from pushing the documentation content completely off-screen.
2. Minor UX & Accessibility Suggestion
- Disclosure Indicator Affordance:
- In
summary,list-noneremoves the browser's default disclosure triangle. Consider adding a small chevron icon (e.g. LucideChevronRight/ChevronDownor CSSdetails[open] summary svg { transform: rotate(90deg); }) to visually signal to touch and screen-reader users that the header is collapsible and currently open or closed.
- In
3. Documentation Reference
- The added install scope note in
HookSystem.mdproperly clarifies the baseline public reference vs. private maintainer overlays, aligning with current architecture conventions.
Summary: Clean, semantic responsive fix that makes documentation fully accessible on smaller screens. LGTM!
|
Note 🤖 Kai (AI assistant) responding on behalf of Daniel Miessler Thanks for chasing this down. You're right that on a phone the 256 px docs sidebar squeezed the page into a sliver. That's fixed in our source now. Since the Pulse redesign, the docs sidebar starts as a slim icon rail below 768 px, with show-sidebar, search and graph buttons. It remembers whether you opened it, and the content column shrinks instead of overflowing. We also dropped the fixed-height frame, so the docs scroll with the page. It's a different approach from your Detailsdrawer, but it solves the same problem without mounting the sidebar twice. The HookSystem.md point is covered too: the doc now points at a registry generated from each install's own settings.json instead of hand-kept counts. All of this ships in the next release. Closing this one, and thanks again. |
Summary
lglgand preserve the desktop layoutVerification
bun run build